Add validation and constraints for generic_keys length in data types and runtime function definitions

Author: Knerio

app/models/data_type.rb

@@ -26,6 +26,8 @@ class DataType < ApplicationRecord
                         in: VARIANTS.keys.map(&:to_s),
                       }
 
+  validate :generic_keys_length
+
   validate :validate_recursion, if: :parent_type_changed?
 
   def validate_recursion
@@ -39,4 +41,9 @@ def validate_recursion
       end
     end
   end
+
+  def generic_keys_length
+    errors.add(:generic_keys, 'each key must be 50 characters or fewer') if generic_keys.any? { |key| key.length > 50 }
+    errors.add(:generic_keys, 'must be 30 or fewer') if generic_keys.size > 30
+  end
 end

app/models/runtime_function_definition.rb

@@ -19,4 +19,12 @@ class RuntimeFunctionDefinition < ApplicationRecord
   validates :runtime_name, presence: true,
                            length: { minimum: 3, maximum: 50 },
                            uniqueness: { case_sensitive: false, scope: :runtime_id }
+
+  validate :generic_keys_length
+
+  def generic_keys_length
+    errors.add(:generic_keys, 'each key must be 50 characters or fewer') if generic_keys.any? { |key| key.length > 50 }
+    errors.add(:generic_keys, 'must be 30 or fewer') if generic_keys.size > 30
+  end
+
 end

db/migrate/20250525192143_implement_generics.rb

@@ -6,6 +6,11 @@ def change
     # https://github.com/code0-tech/tucana/pull/93
 
     add_column :data_types, :generic_keys, 'text[]', null: false, default: []
+    add_check_constraint :data_types,
+                         "NOT EXISTS (
+     SELECT 1 FROM unnest(generic_keys) AS key
+     WHERE length(key) > 50
+   )", name: 'generic_keys_max_length'
 
     create_table :data_type_identifiers do |t|
       # One of them needs to be set will be enforced later
@@ -61,6 +66,12 @@ def change
 
     add_column :runtime_function_definitions, :generic_keys, 'text[]', null: false, default: []
 
+    add_check_constraint :runtime_function_definitions,
+                         "NOT EXISTS (
+     SELECT 1 FROM unnest(generic_keys) AS key
+     WHERE length(key) > 50
+   )", name: 'generic_keys_max_length'
+
     remove_reference :runtime_parameter_definitions, :data_type,
                      foreign_key: { to_table: :data_types, on_delete: :restrict }
     add_reference :runtime_parameter_definitions, :data_type,

spec/models/data_type_spec.rb

@@ -15,6 +15,16 @@
   describe 'validations' do
     it { is_expected.to allow_values(*described_class::VARIANTS.keys).for(:variant) }
 
+    context 'when generic keys are too long' do
+      let(:data_type) { build(:data_type, generic_keys: Array.new(31, 'a' * 51)) } # 31 keys, each 51 characters long
+
+      it 'is expected to be invalid' do
+        expect(data_type).not_to be_valid
+        expect(data_type.errors[:generic_keys]).to include('each key must be 50 characters or fewer')
+        expect(data_type.errors[:generic_keys]).to include('must be 30 or fewer')
+      end
+    end
+
     it 'detects recursions' do
       dt1 = create(:data_type)
       dt2 = create(:data_type, parent_type: create(:data_type_identifier, data_type: dt1))

spec/models/runtime_function_definition_spec.rb

@@ -3,14 +3,26 @@
 require 'rails_helper'
 
 RSpec.describe RuntimeFunctionDefinition do
-  subject { create(:runtime_function_definition) }
+  subject(:function) { create(:runtime_function_definition) }
 
   describe 'validations' do
     it { is_expected.to have_many(:parameters).inverse_of(:runtime_function_definition) }
 
     it { is_expected.to validate_presence_of(:runtime_name) }
     it { is_expected.to validate_uniqueness_of(:runtime_name).case_insensitive.scoped_to(:runtime_id) }
     it { is_expected.to validate_length_of(:runtime_name).is_at_most(50) }
+
+    context 'when generic keys are too long' do
+      before do
+        function.generic_keys = Array.new(31, 'a' * 51) # 31 keys, each 51 characters long
+      end
+
+      it 'is expected to be invalid' do
+        expect(function).not_to be_valid
+        expect(function.errors[:generic_keys]).to include('each key must be 50 characters or fewer')
+        expect(function.errors[:generic_keys]).to include('must be 30 or fewer')
+      end
+    end
   end
 
   describe 'associations' do