tsml_custom_addresses() and imported JSON feeds

[SIA-WEBSUP]

When importing JSON feeds, the addresses are run through Google for geocoding.

When, as happens on occasion, the geocoding is incorrect, TSML has a facility for overriding via tsml_custom_addresses()

However, when the meeting is coming from an external JSON feed, it seems to me that tsml_custom_addresses() is not invoked and the bad geocoding is reinintroduced on re-import.

Is this expected behavior? Is tsml_custom_addresses() invoked when importing a JSON feed?

Or is it the case that tsml_custom_addresses() IS invoked on import, but my JSON is not structured in the correct way for override to be picked up?

Alternatively, can the JSON entry contain more detailed info ( such as latitude / longitude ) that would prevent the bad geocoding from google to take effect without the need for an override via tsml_custom_addresses()?

Example:

Google incorrectly geocodes 1 Cedar Ave, Medford, 11763 to 1 Cedar Ave, Patchogue, 11772.

If you set up a test site to import the following feed which has a single meeting at this location:
https://suffolkny-aa.org/tsml-custom-address-example.json

You'll notice that as part of the import process the address is incorrectly geocoded.

If you then add the following:
if (function_exists('tsml_custom_addresses')) { tsml_custom_addresses(array( '1 Cedar Ave, Medford, 11763, USA' => array( 'formatted_address' => '1 Cedar Ave, Medford, 11763, USA', 'city' => 'Medford', 'latitude' => 40.802802383659184, 'longitude' => -73.01712043064236, 'approximate' => 'no', ), )); }

the override works as expected when editing the meeting from within the TSML plugin's admin screen.

However, if you re-import the JSON feed, the badly geocoded address returns.

So either tsml_custom_addresses() is not run when importing the JSON feed

OR

the way the address is encoded in the JSON does not match up with what tsml_custom_addresses() is expecting for the override to take effect.

Any insight on how I might alter the override in tsml_custom_addresses() (preferable) or change how the JSON encodes the address (less preferable) would be appreciated.

[joshreisner]

looks like your override does not match the data coming in from JSON. try adding another entry for 1 Cedar Ave, MEDFORD, NY, 11763, US to see if that works, or change the JSON to use "formatted_address" => "1 Cedar Ave, Medford, 11763, USA"

[SIA-WEBSUP]

Thanks for the speedy reply @joshreisner

I tried several variations just changing the 'lookup' address in tsml_custom_addresses with no luck

Finally I decide to drop the hammer and add "formatted_address" to the JSON and have the 'lookup' address in tsml_custom_addresses to match.

THIS DID WORK ! THANK YOU !

For the record I was reluctant to do add "formatted_address" to the JSON since the sane thing would be to do this for all meetings and it could potentially introduce some new geocoding issue to some other meeting either on the website or the app, but I wanted to give it a go and we'll have to be on the lookout for any new issues.

Anyhow things are better behaved in that I can get the proper town to appear in the address on the meetings detail page.
see: https://suffolkny-aa.org/meetings/709-mn-00/

Frustratingly however, hitting the directions button still maps out directions to the wrong address, but I'll take the win and keep working on this secondary issue.

For the record here is the code that builds the "formatted_address" in the JSON feed:

'formatted_address' => implode(', ', array_filter([
            $row['locationAddress'],
            $row['locationCity'],
            $row['locationState'],
            $row['locationZip'],
            'US'
        ])),

and here is the override that matches this formatting:

if (function_exists('tsml_custom_addresses')) {
    tsml_custom_addresses(
         array(
            '1 Cedar Ave, MEDFORD, NY, 11763, US' => array(
                'formatted_address' => '1 Cedar Ave, Medford, NY 11763, USA',
                'city' => 'Medford',
                'latitude' => 40.802802383659184,
                'longitude' => -73.01712043064236,
                'approximate' => 'no',
            ),
        )
    );
}