Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Compare page with newer version of React.js #60

Open
natebass opened this issue May 23, 2023 · 2 comments
Open

Rewrite Compare page with newer version of React.js #60

natebass opened this issue May 23, 2023 · 2 comments

Comments

@natebass
Copy link
Member

natebass commented May 23, 2023

The Compare page openbudgetsac.org/compare uses an old version of React.js, which uses deprecated coding standards. Upgrading to the newer version of React.js would require a complete rewrite.

Work has already been started by @PlacidSerene https://github.com/PlacidSerene/openbudget-rework

@MonstersInc-sudo
Copy link

For this refactor are we looking to also update dependencies like ChartJS?

@natebass
Copy link
Member Author

Yeah, we could update as many dependencies as we can to the current version. We would just need to check if there are any breaking API changes that would require us to update our code. I know that this is the case with React; it uses react-cli and makes some breaking changes to the way it declares its components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants