Replaced continue statement with an elseif

fpapadopou · fpapadopou · commit 744bff673ba2 · 2015-11-05T12:30:25.000+02:00
diff --git a/Symfony/src/Codebender/LibraryBundle/Handler/DefaultHandler.php b/Symfony/src/Codebender/LibraryBundle/Handler/DefaultHandler.php
@@ -342,13 +342,13 @@ public function getGithubRepoCode($owner, $repo, $branch, $path)
                     return $code;
                 }
                 $libraryContents['contents'][] = $code['file'];
-                continue;
-            }
-            $directoryContents = $this->getGithubRepoCode($owner, $repo, $branch, $element['path']);
-            if ($directoryContents['success'] !== true) {
-                return $directoryContents;
+            } elseif ($element['type'] == 'dir') {
+                $directoryContents = $this->getGithubRepoCode($owner, $repo, $branch, $element['path']);
+                if ($directoryContents['success'] !== true) {
+                    return $directoryContents;
+                }
+                $libraryContents['contents'][] = $directoryContents['library'];
             }
-            $libraryContents['contents'][] = $directoryContents['library'];
         }
 
         return array('success' => true, 'library' => $libraryContents);

Original file line number	Diff line number	Diff line change
`@@ -342,13 +342,13 @@ public function getGithubRepoCode($owner, $repo, $branch, $path)`
`342`	`342`	`return $code;`
`343`	`343`	`}`
`344`	`344`	`$libraryContents['contents'][] = $code['file'];`
`345`		`- continue;`
`346`		`- }`
`347`		`- $directoryContents = $this->getGithubRepoCode($owner, $repo, $branch, $element['path']);`
`348`		`- if ($directoryContents['success'] !== true) {`
`349`		`- return $directoryContents;`
	`345`	`+ } elseif ($element['type'] == 'dir') {`
	`346`	`+ $directoryContents = $this->getGithubRepoCode($owner, $repo, $branch, $element['path']);`
	`347`	`+ if ($directoryContents['success'] !== true) {`
	`348`	`+ return $directoryContents;`
	`349`	`+ }`
	`350`	`+ $libraryContents['contents'][] = $directoryContents['library'];`
`350`	`351`	`}`
`351`		`- $libraryContents['contents'][] = $directoryContents['library'];`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`return array('success' => true, 'library' => $libraryContents);`