i18n

[Garito]

Hi!
I would like to use your library with internationalization so I was digging the code

Did you notice that moment by itself has the strings your code needs to make the precise range?

Would be nice to make a deeper integration with the dependency and it will gain automatic translation

Are you interested on this issue?

Thanks!!!

[codebox]

Hi,
When I was writing the plugin I looked through the moment.js code to see if it had all the strings I needed, I could find some but not all of them. It would be a much better solution if I could use the built-in strings, for i18n as you describe. Are you sure they are all there (including plurals ie hour/hours etc), if so can you point me to them?
many thanks
Rob

[Garito]

Sure!
You could use _relativeTime. The internationalization mechanism use it to do so

The actual line: https://github.com/moment/moment/blob/develop/moment.js#L947

Cheers!

[codebox]

Yes, I think I saw that when I was looking over the moment.js code - it's close to what I would need, but doesn't quite cover everything. There is no string for '1 second' (the closest is 'a few seconds') and also the singular phrases for minutes, hours etc all use 'a' or 'an' rather than '1' - I think it would look odd if the plugin produced output that was a mixture, like '2 hours a minute 3 seconds' rather than '2 hours 1 minute 3 seconds'

[Garito]

Would be nice to make it very configurable for this kind of things
I think that the correct way to act it to ask to the monents creators to add the few options you miss
I found you by their website, I think they will be ok with your needs

[nlaplante]

👍 for this.

[miguelcobain]

👍

[dellheng]

👍

[dbrgn]

👍

[ZalemCitizen]

👍

[codebox]

I have added a returnValueObject parameter to the preciseDiff methods, setting this value to true will cause the methods to return a value object containing the numeric results of the diff calculation. Hopefully this should help people who require internationalisation - they can let the library do the maths and use their own language files to turn the result into words.

[IvanRF]

@codebox it's a pity you can't reuse relativeTime, you almost have all translations there:

relativeTime : {
            future : 'in %s',
            past : '%s ago',
            s : 'a few seconds',
            m : 'a minute',
            mm : '%d minutes',
            h : 'an hour',
            hh : '%d hours',
            d : 'a day',
            dd : '%d days',
            M : 'a month',
            MM : '%d months',
            y : 'a year',
            yy : '%d years'
},

What if you suggest to add ss : '%d seconds', to moment.js?

[TWiStErRob]

@IvanRF you mean like this? moment/moment#4183