-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datamapper support #11
Comments
Looks good to go to me, although I think it needs a manual merge because of the recent commits. |
Looks good for as far as I can see. I'd like to get rid of the DataMapper specific stuff, but I haven't used DataMapper too often, so I can't really comment on how reasonable that is. Thoughts? :) |
I suggested him to go with the module mixin for datamapper since the methods have just different names. I don't think we can avoid that. Also, arnold.rb is growing bigger and bigger, I think we should begin to split it. |
Yeah, totally agree with @razielgn about splitting. |
Alright, I think we can merge this in. Let's talk about splitting in a new issue. :) |
Did somebody try edit datamapper's model with arnold? We have datamapper branch if you didn't know :)
I think it's ready to be merged and I need some response!
The text was updated successfully, but these errors were encountered: