Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken file coverage due to GitHub response format change #70

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

spalmurray-codecov
Copy link
Collaborator

@spalmurray-codecov spalmurray-codecov commented Mar 26, 2024

Currently coverage when viewing a file is broken. It seems that GitHub started returning HTML here by default - or perhaps something else caused this to happen - regardless, explicitly requesting application/json content type fixes the issue.

Additionally, add regex matchers for detecting file/pr page on GitHub instead of try catch approach

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 26, 2024 15:26
ajay-sentry
ajay-sentry previously approved these changes Mar 26, 2024
@spalmurray-codecov spalmurray-codecov merged commit 33dfa46 into main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants