Merge pull request #46 from codecov/joseph/null-duration

feat: make duration_seconds optional
codecov · Nov 27, 2024 · c840502 · c840502
2 parents 02db067 + 2443547
commit c840502
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 11 deletions.
diff --git a/src/junit.rs b/src/junit.rs
@@ -63,8 +63,7 @@ fn populate(
         .time
         .as_deref()
         .or(testsuite_time)
-        .ok_or_else(|| ParserError::new_err("No time/duration found"))?
-        .parse()?;
+        .and_then(|t| t.parse().ok());
 
     let mut t = Testrun {
         name,

diff --git a/src/testrun.rs b/src/testrun.rs
@@ -85,7 +85,7 @@ pub struct Testrun {
     #[pyo3(get, set)]
     pub classname: String,
     #[pyo3(get, set)]
-    pub duration: f64,
+    pub duration: Option<f64>,
     #[pyo3(get, set)]
     pub outcome: Outcome,
     #[pyo3(get, set)]
@@ -139,7 +139,7 @@ impl Testrun {
     fn new(
         name: String,
         classname: String,
-        duration: f64,
+        duration: Option<f64>,
         outcome: Outcome,
         testsuite: String,
         failure_message: Option<String>,
@@ -162,7 +162,7 @@ impl Testrun {
 
     fn __repr__(&self) -> String {
         format!(
-            "({}, {}, {}, {}, {}, {:?}, {:?}, {:?})",
+            "({}, {}, {}, {:?}, {}, {:?}, {:?}, {:?})",
             self.name,
             self.classname,
             self.outcome,
@@ -276,7 +276,7 @@ mod tests {
         let t = Testrun {
             classname: "".to_string(),
             name: "".to_string(),
-            duration: 0.0,
+            duration: None,
             outcome: Outcome::Pass,
             testsuite: "pytest".to_string(),
             failure_message: None,
@@ -292,7 +292,7 @@ mod tests {
         let t = Testrun {
             classname: "".to_string(),
             name: "".to_string(),
-            duration: 0.0,
+            duration: None,
             outcome: Outcome::Pass,
             testsuite: "".to_string(),
             failure_message: None,
@@ -308,7 +308,7 @@ mod tests {
         let t = Testrun {
             classname: ".py".to_string(),
             name: "".to_string(),
-            duration: 0.0,
+            duration: None,
             outcome: Outcome::Pass,
             testsuite: "".to_string(),
             failure_message: None,
@@ -324,7 +324,7 @@ mod tests {
         let t = Testrun {
             classname: "".to_string(),
             name: ".py".to_string(),
-            duration: 0.0,
+            duration: None,
             outcome: Outcome::Pass,
             testsuite: "".to_string(),
             failure_message: None,
@@ -340,7 +340,7 @@ mod tests {
         let t = Testrun {
             classname: "".to_string(),
             name: "".to_string(),
-            duration: 0.0,
+            duration: None,
             outcome: Outcome::Pass,
             testsuite: "".to_string(),
             failure_message: Some(".py".to_string()),
@@ -356,7 +356,7 @@ mod tests {
         let t = Testrun {
             classname: "".to_string(),
             name: "".to_string(),
-            duration: 0.0,
+            duration: None,
             outcome: Outcome::Pass,
             testsuite: "".to_string(),
             failure_message: Some(".py".to_string()),

diff --git a/tests/no-time.xml b/tests/no-time.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuites>
+    <testsuite name="/file1.xml" tests="2"
+        assertions="2" errors="0" failures="0" skipped="0">
+        <testsuite name="Thing"
+            file="/file1.php"
+            tests="2" assertions="2" errors="0" failures="0" skipped="0">
+            <testcase
+                name="test1"
+                file="/file1.php"
+                line="1"
+                classname="class.className" assertions="1"
+            />
+            <testcase
+                name="test2"
+                file="/file1.php"
+                line="2"
+                assertions="1"
+            />
+        </testsuite>
+    </testsuite>
+</testsuites>
diff --git a/tests/test_junit.py b/tests/test_junit.py
@@ -276,6 +276,13 @@ def test_junit(self, filename, expected, check):
                     ],
                 ),
             ),
+            (
+                "./tests/testsuites.xml",
+                ParsingInfo(
+                    None,
+                    [],
+                ),
+            ),
         ],
     )
     def test_junit(self, filename, expected):

diff --git a/tests/testsuites.xml b/tests/testsuites.xml
@@ -0,0 +1 @@
+<testsuites name="empty_testsuites" tests="0" failures="0" />