Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make duration_seconds optional #46

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

also adds a test for a JUnit XML that only has a single empty testsuites tag

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.34%. Comparing base (3348c31) to head (2443547).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/testrun.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   87.50%   85.34%   -2.16%     
==========================================
  Files           5        5              
  Lines         568      587      +19     
==========================================
+ Hits          497      501       +4     
- Misses         71       86      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/testrun.rs 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

src/junit.rs Outdated Show resolved Hide resolved
@joseph-sentry joseph-sentry merged commit c840502 into main Nov 27, 2024
8 of 11 checks passed
@joseph-sentry joseph-sentry deleted the joseph/null-duration branch November 27, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants