Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buffer location to error message #53

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

joseph-sentry
Copy link
Contributor

we want to make it easier to find the cause of a parsing error so i am adding the error location to the error message

we want to make it easier to find the cause of a parsing error so i am
adding the error location to the error message
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.34%. Comparing base (3348c31) to head (3d4a26d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/junit.rs 25.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   87.50%   85.34%   -2.16%     
==========================================
  Files           5        5              
  Lines         568      587      +19     
==========================================
+ Hits          497      501       +4     
- Misses         71       86      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/junit.rs 25.00% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@joseph-sentry joseph-sentry merged commit 02db067 into main Nov 27, 2024
6 of 11 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-error-info branch November 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants