Add notification for inaccessible documents #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working so far from my testing. However, I hesitate approving it just yet because it involves interaction with Solid and I have less experience on that aspect of the app. I'd like to wait for input from the development side and then can approve. Thank you for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves #694
1.
2. If needed, delete if not
3. If needed, delete if not
Screenshots (if applicable):
Add any screenshots/videos here.
Additional Context (optional):
Add any other context about the PR here.
I added a try-catch block to the handleShowDocumentLocal function in the DocumentTable component to handle the case where a user doesn't have access to a document. If a 403 error occurs (Unauthorized), the catch block triggers a notification informing the user they don't have permission to view the document.
@Jared-Krajewski @timbot1789 @xscottxbrownx @leekahung
Please review the changes and let me know if there are any adjustments or improvements needed.
Future Steps/PRs Needed to Finish This Work (optional):
Add any other steps/PRs that may be needed to continue this work if this PR is just a step in the right direction.
Issues needing discussion/feedback (optional):
1.
2. If needed, delete if not
3. If needed, delete if not