Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] - Adding a non-existant contact displays an exception message #697

Open
lee-coates opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lee-coates
Copy link

Describe the bug:

When adding a contact that does not exist in the pod, an exception message is displayed on the web page instead of informing the user that the contact could not be found. The exception message is long and likely would not make sense to an end user.

Current Error Message:
Add contact failed. Reason: Fetching the Resource at [http://localhost:3000/test-name/profile/card#me] failed: [404] [Not Found] <b0> <http://purl.org/dc/terms/title> "NotFoundHttpError"; <http://purl.org/dc/terms/description> "".

Expected behavior:

If the user adds a contact that does not exist, the displayed message should indicate that the contact could not be found in the pod. The message could further inform the user to ensure the contact's name matches the username the contact signed up for in the same pod.

Actual Behavior:

If the user adds a contact that does not exist, the displayed message includes technical information that is unhelpful to end users.

Screenshots:

codepdx_issue_add_contact_error_message

To Reproduce:

Steps to reproduce the behavior:

  1. Login and navigate to Add Contact
  2. Fill in the OIDC Provider and a bogus username
  3. Hit add contact
  4. See error

Desktop (please complete the following information):

  • OS: Fedora 41, KDE Plasma 6.2.3
  • Browser: Firefox
  • Version: 132.0.1 (64-bit)

Possible Fix:

If the caught exception notes that a correctly formatted username was not found, then the message should indicate the user does not exist or could not be found.

Additional context:

This has only been tested with a local pod. Testing with community pods is yet to be tested.

@lee-coates lee-coates added the bug Something isn't working label Nov 19, 2024
@andycwilliams andycwilliams added the good first issue Good for newcomers label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants