Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from cleanup-after-sync-: cannot use generate name with apply #63

Open
letthefireflieslive opened this issue Nov 22, 2022 · 5 comments
Open

Comments

@letthefireflieslive
Copy link

Encountered in Sync hook and waves exercise, last exercise

@Lp-Francois
Copy link
Contributor

Hello! Could you share the file throwing the error and the exercise text?
You maybe miss a part asking you to add more YAML to the file and commit it (and as it is incomplete, Argo complains)

@letthefireflieslive
Copy link
Author

https://github.com/codefresh-contrib/gitops-cert-level-2-examples/tree/6e01c3c10a02807edf8e534135cb382695469537

Yeah maybe, because if i remember it right, i tried to create the app with the auto create namespace unchecked and i just deleted the app again and recreate... i forgot how to replicate sorry

@Lp-Francois
Copy link
Contributor

Pretty sure it is because you were missing the hook annotation, I remember having a similar issue

with this: https://github.com/codefresh-contrib/gitops-cert-level-2-examples/blob/main/sync-hooks-waves/03-postsync-cleanup/cleanup.yml it will give you an error, but if you uncomment it should work

@kostis-codefresh
Copy link
Member

kostis-codefresh commented Oct 16, 2023

Hello @letthefireflieslive

Your solution seems to miss the syncwave annotation. I only see the phase annotation on your file.

Anyway, I just tried the last exercise again myself and I don't see any errors
See attached screenshot

The expected solution is actually provided in the same repo :-)

https://github.com/codefresh-contrib/gitops-cert-level-2-examples/tree/main/solutions/sync-hooks-waves/06-waves-and-hooks

solution

everything-syncs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants