From 6f3f1e87f48ac1604c47ad05db66aae755886176 Mon Sep 17 00:00:00 2001 From: Daniel Maizel Date: Sat, 24 Feb 2024 11:52:21 +0200 Subject: [PATCH] Add a log message in case of hosted runtime uninstall (#739) ## What ## Why ## Notes --- Makefile | 2 +- cmd/commands/runtime.go | 6 ++---- docs/releases/release_notes.md | 4 ++-- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 56e3f6ef..3eb7b3d6 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -VERSION=v0.1.61 +VERSION=v0.1.62 OUT_DIR=dist YEAR?=$(shell date +"%Y") diff --git a/cmd/commands/runtime.go b/cmd/commands/runtime.go index ebea8312..b388e6ba 100644 --- a/cmd/commands/runtime.go +++ b/cmd/commands/runtime.go @@ -578,11 +578,9 @@ func runRuntimeUninstall(ctx context.Context, opts *RuntimeUninstallOptions) err return err } - log.G(ctx).Infof("Deleting runtime \"%s\" from platform", opts.RuntimeName) + err = deleteRuntimeFromPlatform(ctx, opts) if opts.Managed { - _, err = cfConfig.NewClient().GraphQL().Runtime().DeleteManaged(ctx, opts.RuntimeName) - } else { - err = deleteRuntimeFromPlatform(ctx, opts) + log.G(ctx).Infof("It may take up to 5 minutes until your hosted runtime will be fully deleted") } handleCliStep(reporter.UninstallStepDeleteRuntimeFromPlatform, "Deleting runtime from platform", err, false, !opts.Managed) if err != nil { diff --git a/docs/releases/release_notes.md b/docs/releases/release_notes.md index 3863d48f..0a968fcd 100644 --- a/docs/releases/release_notes.md +++ b/docs/releases/release_notes.md @@ -23,7 +23,7 @@ cf version ```bash # download and extract the binary -curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.61/cf-linux-amd64.tar.gz | tar zx +curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.62/cf-linux-amd64.tar.gz | tar zx # move the binary to your $PATH mv ./cf-linux-amd64 /usr/local/bin/cf @@ -36,7 +36,7 @@ cf version ```bash # download and extract the binary -curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.61/cf-darwin-amd64.tar.gz | tar zx +curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.62/cf-darwin-amd64.tar.gz | tar zx # move the binary to your $PATH mv ./cf-darwin-amd64 /usr/local/bin/cf