Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagerDuty step does not fully support Events v2 API #696

Open
kiyanmair opened this issue Jul 14, 2024 · 0 comments · May be fixed by #697
Open

PagerDuty step does not fully support Events v2 API #696

kiyanmair opened this issue Jul 14, 2024 · 0 comments · May be fixed by #697

Comments

@kiyanmair
Copy link

PagerDuty's Events API v2 (docs) allows sending two types of events: standard events (docs) and change events (docs). They both use a routing/integration key, while PagerDuty's REST API v2 uses an API key.

Currently, the official PagerDuty step provided by Codefresh implements the REST API for the PAGERDUTY_ALERT_TYPE of incident, and only the change events subset of the Events API for the PAGERDUTY_ALERT_TYPE of change_event. This means that users of the Events API can only send change events, but not trigger incidents by sending a normal event.

The PagerDuty step should support the entire Events API instead of just a subset. This can be done without breaking backwards compatibility. The step uses PagerDuty's pdpyras client to send requests, and implementation is as simple as importing its existing EventsAPISession.

Personally, I've had to implement my own custom PagerDuty step to create alerts from Codefresh, which isn't ideal.

@kiyanmair kiyanmair linked a pull request Jul 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant