refactor: do not override Exception's $code in RedirectException

Author: paulbalandan

system/HTTP/Exceptions/RedirectException.php

@@ -27,11 +27,9 @@
 class RedirectException extends RuntimeException implements ExceptionInterface, ResponsableInterface, HTTPExceptionInterface
 {
     /**
-     * HTTP status code for redirects
-     *
-     * @var int
+     * Status code applied to a Response that arrives without a 3xx redirect status.
      */
-    protected $code = 302;
+    protected int $defaultStatusCode = 302;
 
     protected ?ResponseInterface $response = null;
 
@@ -61,7 +59,7 @@ public function __construct($message = '', int $code = 0, ?Throwable $previous =
             }
 
             if ($this->response->getStatusCode() < 301 || $this->response->getStatusCode() > 308) {
-                $this->response->setStatusCode($this->code);
+                $this->response->setStatusCode($this->defaultStatusCode);
             }
         }
 

user_guide_src/source/changelogs/v4.8.0.rst

@@ -42,6 +42,7 @@ Behavior Changes
 - **Filters:** HTTP method matching for method-based filters is now case-sensitive. The keys in ``Config\Filters::$methods`` must exactly match the request method
   (e.g., ``GET``, ``POST``). Lowercase method names (e.g., ``post``) will no longer match.
 - **HTTP:** Routes defined with ``$routes->add()`` now also match HTTP ``QUERY`` requests. If the route has CSRF protection, remember that CSRF verification does not protect safe methods such as ``GET`` and ``QUERY``.
+- **HTTP:** ``CodeIgniter\HTTP\Exceptions\RedirectException`` no longer redeclares the inherited ``$code`` property. The status applied to a ``Response`` passed to the constructor without a 3xx status now comes from the new ``protected int $defaultStatusCode = 302`` property. Subclasses that overrode ``$code`` to change that status must override ``$defaultStatusCode`` instead.
 - **Testing:** Tests using the ``FeatureTestTrait`` must now use uppercase HTTP method names when performing a request when using the ``call()`` method directly
   (e.g., ``$this->call('GET', '/path')`` instead of ``$this->call('get', '/path')``). Additionally, setting method-based routes using ``withRoutes()`` must
   also use uppercase method names (e.g., ``$this->withRoutes([['GET', 'home', 'Home::index']])``).

utils/phpstan-baseline/property.phpDocType.neon

@@ -73,9 +73,9 @@ parameters:
             path: ../../system/Exceptions/PageNotFoundException.php
 
         -
-            message: '#^PHPDoc type int of property CodeIgniter\\HTTP\\Exceptions\\RedirectException\:\:\$code is not the same as PHPDoc type mixed of overridden property Exception\:\:\$code\.$#'
+            message: '#^PHPDoc type CodeIgniter\\HTTP\\URI of property CodeIgniter\\HTTP\\IncomingRequest\:\:\$uri is not the same as PHPDoc type CodeIgniter\\HTTP\\URI\|null of overridden property CodeIgniter\\HTTP\\OutgoingRequest\:\:\$uri\.$#'
             count: 1
-            path: ../../system/HTTP/Exceptions/RedirectException.php
+            path: ../../system/HTTP/IncomingRequest.php
 
         -
             message: '#^PHPDoc type string of property CodeIgniter\\Session\\Handlers\\FileHandler\:\:\$savePath is not the same as PHPDoc type array\<string, mixed\>\|string of overridden property CodeIgniter\\Session\\Handlers\\BaseHandler\:\:\$savePath\.$#'