Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: NetBeans IDE-related entries in the framework_root/.gitignore file are causing issues #9423

Closed
nalakapws opened this issue Jan 20, 2025 · 2 comments · Fixed by #9428
Closed
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@nalakapws
Copy link
Contributor

nalakapws commented Jan 20, 2025

PHP Version

8.3

CodeIgniter4 Version

4.5.8

CodeIgniter4 Installation Method

Composer (using codeigniter4/appstarter)

Which operating systems have you tested for this bug?

Windows

Which server did you use?

apache

Database

PostgreSQL 16

What happened?

Current Netbeans IDE related entries in the framework_root/.gitignore file apply for the whole repository recursively. This can cause issues when we use like third-party libraries and packages. because its pertty common to have directories like 'dist', 'build' in them. those directories can get ignored.

Since I don't use Netbeans, i don't know where those directories get ceated. I think they get created in the project root. If so, I propose these entries as a replacement for the current ones.

# NetBeans /nbproject/ /build/ /nbbuild/ /dist/ /nbdist/ /nbactions.xml /nb-configuration.xml /.nb-gradle/

Steps to Reproduce

Explained in the description.

Expected Output

Explained in the description.

Anything else?

No response

@nalakapws nalakapws added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 20, 2025
@paulbalandan
Copy link
Member

paulbalandan commented Jan 20, 2025

Hi, may I confirm if you are using this repo for your development?

Edit: Ok, I saw that starter's gitignore is the same with here. If you can open a PR with those changes, that would be great!

@nalakapws
Copy link
Contributor Author

nalakapws commented Jan 20, 2025

PR sent #9427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
2 participants