Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to scrape javascript intensive apps #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sosshi
Copy link

@Sosshi Sosshi commented Jun 12, 2022

The library was failing to scrape sites which have javascript code in it so i have added the ability to scrape such websites. So now it will be possible to scrape sites made with Vue, React and other JS intensive frameworks

@banagale
Copy link

This sounds compelling. I noticed your change sent includes conversion of single to double quotes and some formatting.

It would be easier to review these changes if it were limited only to materially changed lines.

While I do not believe the maintainer is approving PRs at this time, in general I'd suggest offering a PR with changes that only include what you're working on. Then consider a second that affects formatting in a more general sense.

--

All that said, I'm curious if you have test cases of sites that show article content using JS that fail using the main branch but pass using your change set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants