-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed ability to execute tests with/without isolation between tests #2054
Conversation
Update from origin
It was impossible to execute TestRunner with cleanMode = false. So if cleanMode must be false by default so we can use both.
update my fork
Sorry this pull request contains some invalid commits |
Can you merge just the commit with the fix please |
If I understood this correctly this is a patch for one line flipping a boolean value from true to false? |
Yes that it. No there no other changes. Sorry I'm not so familiar with github. Actually, I just want to pull request "fix attribute cleanMode in TestRunner" commit ... |
Github is a bit of a problem. Not sure how it got this way but the merge seems to be messed up a bit. |
I agree with you. But actually, you can't execute tests without isolation with this code !! |
So the correct fix would be to fix that, no? |
Yes it is ! |
After reflexion, I think it should be better to accept my commit, and edit your |
That would take some work. Changing the build.xml means going thru a plugin update cycle and doing it for the 3 IDE's. Not trivial. |
A proposition to fix codenameone#2054
A proposition to fix codenameone#2054
@all-contributors please add @JrmyDev for code |
I've put up a pull request to add @JrmyDev! 🎉 |
No description provided.