Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update and start" is not triggering two builds. #13539

Open
BrunoQuaresma opened this issue Jun 11, 2024 · 3 comments
Open

"Update and start" is not triggering two builds. #13539

BrunoQuaresma opened this issue Jun 11, 2024 · 3 comments
Labels
bug Used to filter all bug issues customer-reported Bugs reported by enterprise customers must-do Issues that must be completed by the end of the Sprint. Or else. s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Jun 11, 2024

When updating and starting a workspace the following builds should be triggered:

  • transition=stop, template_version=old
  • transition=start, template_version=new

But it looks like it is not happening on 2.12.1.

Reported by @spikecurtis

@BrunoQuaresma BrunoQuaresma added site Area: frontend dashboard s2 Broken use cases or features (with a workaround). Only humans may set this. bug Used to filter all bug issues labels Jun 11, 2024
@BrunoQuaresma BrunoQuaresma self-assigned this Jun 11, 2024
@BrunoQuaresma
Copy link
Collaborator Author

I look at the files where this could happen but looks like we don't stop the workspace before starting a new "start build" for updates and it has been like that for a while.

Places where it could be changed:

@BrunoQuaresma BrunoQuaresma removed their assignment Jun 11, 2024
@BrunoQuaresma BrunoQuaresma added customer-reported Bugs reported by enterprise customers and removed site Area: frontend dashboard labels Jun 11, 2024
@stirby stirby closed this as completed Jun 21, 2024
@stirby stirby reopened this Jun 21, 2024
@stirby
Copy link
Collaborator

stirby commented Jun 21, 2024

Did not mean to close, misclick.

@bpmct bpmct added the must-do Issues that must be completed by the end of the Sprint. Or else. label Jun 27, 2024
@matifali
Copy link
Collaborator

We can follow the same process for workspace which are pending auto deletion but have an update available.
Currently

  • transition=delete, template_version=old

which fails the deletion as the old template has some values not valid anymore e.g. (the docker host address has been updated)

It should be

  • transition=start, template_version=new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to filter all bug issues customer-reported Bugs reported by enterprise customers must-do Issues that must be completed by the end of the Sprint. Or else. s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Development

No branches or pull requests

4 participants