You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On data mutation, it will check if block element contains the mutated wrapper tune element, and will always fail, as it is a wrapper, and not a child of the block.
Create a tune with a wrapper element / install editorjs-alignment-blocktune mentioned above
Try setting a tune for the block
onChange is not called
Expected behavior:
if this is intended, should all tunes use dispatchChange() on tune change starting from v2.27.0-rc.5?
if not, then, I think the onChange should be called regardless if mutated element is part of a block. (E.g. What happens if there is some button outside of EditorJS container, that would, change a tune for all blocks (backgrounds, alignments, etc.)?)
Screenshots:
The ce-tune-alignment--center is the tune wrapper element, and ce-paragraph is the block element, didMutated will not be called whenever wrapper is mutated, as it is not part of block element.
Creating a custom tune, if a wrapper element is used, it will not call didMutated, and because of it, onChange is also not called.
Issue comes from v2.27.0-rc.5 : b7b00fd#diff-3a2e107229dbebf0e0b7e00160e7faec0cf71e6baf51872078e031789692c8b5R934
On data mutation, it will check if block element contains the mutated wrapper tune element, and will always fail, as it is a wrapper, and not a child of the block.
kaaaaaaaaaaai/editorjs-alignment-blocktune#12
kaaaaaaaaaaai/editorjs-alignment-blocktune#13
Steps to reproduce:
Expected behavior:
if this is intended, should all tunes use
dispatchChange()
on tune change starting from v2.27.0-rc.5?if not, then, I think the onChange should be called regardless if mutated element is part of a block. (E.g. What happens if there is some button outside of EditorJS container, that would, change a tune for all blocks (backgrounds, alignments, etc.)?)
Screenshots:
The
ce-tune-alignment--center
is the tune wrapper element, andce-paragraph
is the block element, didMutated will not be called whenever wrapper is mutated, as it is not part of block element.Device, Browser, OS: any
Editor.js version: v2.27.0-rc.5 and above
Plugins you use with their versions:
https://github.com/kaaaaaaaaaaai/editorjs-alignment-blocktune 1.0.3
The text was updated successfully, but these errors were encountered: