-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Suffix Tree #290
Comments
can you please assign this issue to me? @prshnt19 |
Thanks @prshnt19 for sharing the issue policy. |
Let me take up this one @czgdp1807 |
Sure. |
This would initialise a new suffix tree. Rest of the parameters will be same as other tree implementation.
Additional features
|
Can you pick example where suffix tree is used and show how above APIs will be used in that example? There might be an example on Wikipedia or some other website. |
https://www.cise.ufl.edu/~sahni/dsaaj/enrich/c16/suffix.htm hope in this site we get the example with analyzation |
As suffix tree isn't like any other binary tree i hope it has to be implemented in separate file and shall I go on with that @czgdp1807 |
Following are the questions and concerns,
Comments on API
I feel that this is a bit complicated. Most of the literature writes about creating suffix trees from a set of strings. So, the API should be as simple as,
This depends on whether we want to keep static or dynamic. If there are algorithms for updating a dynamic trees then we can go for it. However, what is meant by
Why do we need it? Mostly suffix trees are used to perform queries on strings, so this method may not provide very useful information. Any examples where
They both should accept strings (set of strings or a single string should be decided upon). More features given in https://en.wikipedia.org/wiki/Suffix_tree#Applications should also be added. |
As far my research on the above tree after the conversation I will take those changes and reframe the API |
suffix
The implementation of several features are quite complicated I hope it should be done step by step. |
Sounds good. Though, we should have generalised suffix tree which should be capable of storing information about a set of strings. The tricky part is to end each string in the set with a different terminal symbol.
You can start with implementing the logic for building the suffix tree and then add features in each new commit. Please do it locally and push only when the tests you add for suffix tree are passing. |
@czgdp1807 Cool, I'm working on that |
If this issue is open can u please assign me |
Description of the problem
Example of the problem
References/Other comments
[1] https://en.wikipedia.org/wiki/Suffix_tree
The text was updated successfully, but these errors were encountered: