New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: generalising expander class #5

Open

dengemann opened this issue Apr 20, 2021 · 0 comments

Collaborator

dengemann commented Apr 20, 2021

Currently, the expander code rigidly assumes that the last column in the data frame is the indicator for computing interaction effects.

This is problematic in at least two ways.

It is very implicit; a label would be better.
It is only one out of many possible ways of doing feature expansions.

I suggest we generalise the API to allow using different (future) possible expander objects that can be passed instead of using a logical parameter.

dengemann mentioned this issue

ENH: ExpandFeatures tests #7

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment