Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing http-client config options to client function #64

Closed
dmarjenburgh opened this issue Mar 4, 2019 · 4 comments
Closed

Allow passing http-client config options to client function #64

dmarjenburgh opened this issue Mar 4, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@dmarjenburgh
Copy link

I'm specifically interested in passing proxy-host and proxy-port, but in general it'd be nice if you could pass your own config into the http-client.

For example, like this:

(require '[cognitect.aws.client.api :as aws])
(aws/client {:api :s3
             :http-client-config {:proxy-host "10.0.30.40"
                                  :proxy-port 9400}})
@dchelimsky dchelimsky added the enhancement New feature or request label Mar 6, 2019
dchelimsky added a commit that referenced this issue Mar 26, 2019
@dchelimsky
Copy link
Contributor

:endpoint-override map added in 0.8.280. You can supply :protocol, :hostname, :port, and :path.

@borgesgabriel
Copy link

I'm not sure that this issue has been fully addressed.

Referring back to @dmarjenburgh's ask, proxy-host and proxy-port create a org.eclipse.jetty.client.Socks4Proxy, and cannot be specified in :endpoint-override as far as I can tell.

@gzmask
Copy link

gzmask commented Nov 23, 2020

I agree with @borgesgabriel . This is not the same thing.

@xiongtx
Copy link

xiongtx commented Mar 10, 2023

See #181 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants