We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current implementation looks like this: <Icon name="controls_plus" />
<Icon name="controls_plus" />
Or from Button <Button right_icon="controls_plus" />
<Button right_icon="controls_plus" />
This is not good, because this implementation has 2 problems:
I PROPOSE TO use slots and named icons: <Button><:left_icon><ControlsPlus /></:left_icon></Button>
<Button><:left_icon><ControlsPlus /></:left_icon></Button>
EDIT: New version of LiveView/Surface supports components as arguments, so maybe this is not a as big problem.
The text was updated successfully, but these errors were encountered:
Proposal looks fine to me.
Sorry, something went wrong.
I agree with this approach 😊
No branches or pull requests
Current implementation looks like this:
<Icon name="controls_plus" />
Or from Button
<Button right_icon="controls_plus" />
This is not good, because this implementation has 2 problems:
I PROPOSE TO use slots and named icons:
<Button><:left_icon><ControlsPlus /></:left_icon></Button>
EDIT:
New version of LiveView/Surface supports components as arguments, so maybe this is not a as big problem.
The text was updated successfully, but these errors were encountered: