-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple on one page #101
Comments
heya- it doesn't target the input based on the ID (since v1.1.0). Though it isn't intended to be used on more than 1 on a page. I can't think of a valid use-case where that would be necessary. Could you let me know why you'd want more than one on a page? You should never be able to see other users passwords since they wouldn't/shouldn't be stored in plain-text. |
Sure. I have a form for creating an account and it has a password, confirm password and security answer fields that I wanted to have a show/hide button for. |
I think if you have a 'show password toggle' button then maybe you won't need a confirm password input? There is research showing that confirm password fields is bad UX. e.g. |
Ya, I agree about confirm password, I was giving scenarios where multiple might be needed. Still the security answer though. |
Hello what about changing passwords like input old password then have an input for new password would be nice to have it on more then one input |
Encountering this too +1 |
that's true, i hope you fix it and use selector instead of id for the button |
I think from a 30 second peek at the code that this can only be used for one input on the page because it is targeting the button by a specific ID. Or am I wrong?
The text was updated successfully, but these errors were encountered: