Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving CLI functionality #3

Open
TheChymera opened this issue Aug 1, 2017 · 5 comments
Open

Improving CLI functionality #3

TheChymera opened this issue Aug 1, 2017 · 5 comments

Comments

@TheChymera
Copy link

Hello, I finally got around to cloning, testing, and having a closer look at this. Your code looks fairly simple and straightforward, especially compared to e.g. Pyper.

Ideally, though, in order to accommodate more functionalities (e.g. explicit target file specification, batch processing, different evaluation metrics) , the script functionality would be covered by a CLI.

This would require a bit of code rearrangement.

I'm basically writing to ask whether you would be interested to pull. If not, I might instead want to fork your code into behaviopy.

@Haptein
Copy link

Haptein commented Aug 12, 2017

Hi, I'm also interested in contributing. I've gone ahead and forked your code in order for it to work with a wider range of experimental settings and would be happy to help here if you're interested in pulling and you see these changes fit to the way you want your code to work. I've also written some changes in regard to CLI functionality and some other stuff.
PS. The forked work here isn't up to date, since I'm currently away from home.

@TheChymera
Copy link
Author

TheChymera commented Aug 14, 2017

@Haptein cool! Could you show us a link to your forked code? While the author responds I would be interested to have a look at your code and see if it can already address (or whether I can easily hack it to address) my present use case.

Basically, if you're also interested in extending the scope, you could try and have a look at a sample recording from our lab, I uploaded one here. The issues I have encountered with the original code available here is:

  • It assumes a square stage.
  • It relies on high stage-to-walls contrast.
  • It does not work with .mkv.

@Haptein
Copy link

Haptein commented Aug 14, 2017

@TheChymera The fork is here. Although I wouldn't pay too much attention to it since it's been heavily modified since and is on a very incomplete stage. I'll update it as soon as I go back home, which should happen later this month.

About the issues you mentioned. The original code indeed assumes a list of hard-coded values and stuff about the experiments. The up-to-date fork doesn't assume a square stage and doesn't rely on stage Vs. wall contrast. The automatic stage area selection is something I completely removed for the time being, it made working with acrylic floor/walls troublesome and I think it's more convenient to save the selected region specs instead. I also added a config utility.

I didn't encounter any problem working with mkv files with the fork, but I don't think it should be any different with the original code. I think it might have something to do with your OpenCV version, although I'm not completely sure. I've been working with OpenCV 3.3.

@TheChymera
Copy link
Author

I'm on =opencv-3.2.0

@Haptein
Copy link

Haptein commented Aug 16, 2017

I just tried the original code with your video and it loads it but indeed fails because the hard-coded assumptions about your experimental setting. Have you tried converting the included 'rat.avi' to .mkv and running the code with it? What's your error output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants