Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start is not very quick, fails to mention wrapping in 'did-finish-load' event #8

Open
cramatt opened this issue Mar 6, 2019 · 0 comments

Comments

@cramatt
Copy link

cramatt commented Mar 6, 2019

The quick start code is almost there, but to get the renderer process working I needed to put the example code inside of https://electronjs.org/docs/api/web-contents#event-did-finish-load

browserWindow.webContents.on('did-finish-load', () => {
 .. example renderer code here
})

It would be much more useful to newcomers if this was included in the README.

@cramatt cramatt changed the title Quick start is not very quick because it fails to mention needing to put renderer code inside webContents.on('did-finish-load' Quick start is not very quick, fails to mention wrapping in 'did-finish-load' event Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant