Add precompile to qa.cfg?

[idgserpro]

Since in qa.cfg we already have "${buildout:package-name}", what about adding this part so packages that rely on this for testing can just add a precompile part after extending qa.cfg?

[precompile]
# Needed to create *.mo for tests.
recipe = plone.recipe.precompiler
eggs = ${buildout:package-name}
compile-mo-files = true

@mauritsvanrees thoughts?

[jensens]

since tests are most of the time run once (like in CI) - what do we gain?

[idgserpro]

since tests are most of the time run once (like in CI) - what do we gain?

A DRY principle, mostly. If you have ten packages that need *.po compilation (for some CI environments where the workspace is alwayes destroyed between builds), instead of adding this snippet to all of the packages, you only add the precompile part after extending buildout.plonetest.

[jensens]

OK. If there are benefits, why not?

[mauritsvanrees]

So add this in qa.cfg and also add precompile to the list of parts there?
Seems okay. I don't know if this helps in tests: probably only when you have a test that explicitly checks for a translation.
But I suppose running the part can uncover errors in Python files and in po files.

[idgserpro]

Actually, I was planning to just add a precompile part, to qa.cfg, but not in parts itself.

We have the part rebuild_i18n-sh, but it isn't in qa.cfg parts: if you want to use it, you need to add to your own buildout.cfg parts section.

For the precompile, I want to keep this behavior. The idea is just to avoid copy and paste for the precompile part (the same motivation for rebuild_i18n-sh I suppose).