Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions/Fields schemaeditor is broken in Plone 5 #354

Open
laulaz opened this issue Jun 18, 2022 · 5 comments
Open

Actions/Fields schemaeditor is broken in Plone 5 #354

laulaz opened this issue Jun 18, 2022 · 5 comments

Comments

@laulaz
Copy link
Member

laulaz commented Jun 18, 2022

In Plone 5(.2), the actions/fields schemaeditor JS is not called --> some features are broken (ex: drag & drop, delete confirmation message, ...).

++resource++schemaeditor.js was removed in d9ee5fa

Its code is now part of a pattern in plone.staticresources (see plone/plone.schemaeditor@c857839 and plone/mockup@d9b418f) but not in 1.4.6 (the version used in Plone 5.2).

I don't know what is the best way to fix this ...

@MrTango
Copy link
Contributor

MrTango commented Jun 20, 2022

@frapell / @jensens any idea?
I noticed probably the same bug, when adding a field to a fieldset other than defaul. The modal is broken then.

@jensens
Copy link
Member

jensens commented Jun 20, 2022

No good idea whats wrong. But this indeed a bug.

@frapell
Copy link
Member

frapell commented Jun 22, 2022

@MrTango Unfortunately I am unable to work on this right now, but will put it in my queue to take a look when I free up

@frapell
Copy link
Member

frapell commented Jul 22, 2022

@laulaz @MrTango I am not sure if the schemaeditor and mockup changes are intended to be used in Plone 5.X so, I think we have 2 options with easyform:

  1. Keep it as it is, and have version 4.x be Plone 6 only and 3.x for Plone 5
  2. Bring back the forms as they were from before this change d9ee5fa and load one template or the other, depending if it is in Plone 5 or Plone 6, and so easyform version 4 will keep supporting Plone 5

What do you guys think?

@laulaz
Copy link
Member Author

laulaz commented Jul 25, 2022

@frapell I would personally go for 1 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants