Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No license? #328

Open
comradekingu opened this issue Sep 7, 2021 · 5 comments
Open

No license? #328

comradekingu opened this issue Sep 7, 2021 · 5 comments

Comments

@comradekingu
Copy link
Contributor

Would expect to find it in the form of "COPYING" or similar at the root of the directory.
@jensens
Copy link
Member

jensens commented Sep 8, 2021

see
https://github.com/collective/plone.app.locales/blob/master/setup.py#L40
but I agree, a license file is missing.

@erral erral closed this as completed in 13ef4a2 Sep 16, 2021
erral added a commit that referenced this issue Sep 16, 2021
@erral
Merge pull request #329 from collective/add-license-1
3f42ec6 
fixes #328
@mauritsvanrees
Copy link
Member

But we have docs/LICENSE.GPL. Either the new or the old LICENSE should be removed, and setup.py / MANIFEST.in updated. The contents are the same.

@mauritsvanrees mauritsvanrees reopened this Oct 7, 2021
@erral erral mentioned this issue Oct 7, 2021
Merged
mauritsvanrees added a commit that referenced this issue Oct 15, 2021
@mauritsvanrees
Merge pull request #333 from collective/revert-329-add-license-1
e5e13be 
Revert "fixes #328"
@jensens
Copy link
Member

jensens commented Oct 15, 2021

https://github.com/collective/plone.app.locales/community does not show a license. So it is not visible enough as it is.

@jensens jensens reopened this Oct 15, 2021
@mauritsvanrees
Copy link
Member

I have never looked there in any package.

@jensens
Copy link
Member

jensens commented Oct 18, 2021

You usually don't - its shown in the right column like here in CMFplone:
Screenshot from 2021-10-18 09-49-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jensens @mauritsvanrees @comradekingu