Skip to content

Commit 514845f

Browse files
authored
Merge pull request #811 from tcfx44/master
Support for ext CAN IDs in wireshark files
2 parents d97c8d4 + 105c7a0 commit 514845f

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

framefileio.cpp

+7-3
Original file line numberDiff line numberDiff line change
@@ -5064,9 +5064,13 @@ bool FrameFileIO::loadWiresharkFile(QString filename, QVector<CANFrame>* frames)
50645064
thisFrame.isReceived = true; // TODO: check if tx detection is possible
50655065

50665066
thisFrame.setFrameType(QCanBusFrame::DataFrame);
5067-
thisFrame.setFrameId((0xff & *(packetData+17)) << 8 | (0xff & *(packetData+16)));
5068-
if (thisFrame.frameId() <= 0x7FF) thisFrame.setExtendedFrameFormat(false);
5069-
else thisFrame.setExtendedFrameFormat(true);
5067+
if ((0x80 & *(packetData+19))) {
5068+
thisFrame.setExtendedFrameFormat(true);
5069+
thisFrame.setFrameId((0x3f & *(packetData+19))<<24 | (0xff & *(packetData+18)) << 16 | (0xff & *(packetData+17)) << 8 | (0xff & *(packetData+16)));
5070+
} else {
5071+
thisFrame.setExtendedFrameFormat(false);
5072+
thisFrame.setFrameId((0xff & *(packetData+17)) << 8 | (0xff & *(packetData+16)));
5073+
}
50705074
thisFrame.bus = 0;
50715075
int numBytes = *(packetData+20);
50725076
QByteArray bytes(numBytes, 0);

0 commit comments

Comments
 (0)