Fix Grammar::substituteBindingsIntoRawSql fails during unnesting (#246)

Author: zeriyoshi

src/Connection.php

@@ -20,6 +20,7 @@
 use Closure;
 use Colopl\Spanner\Query\Builder as QueryBuilder;
 use Colopl\Spanner\Query\Grammar as QueryGrammar;
+use Colopl\Spanner\Query\Nested;
 use Colopl\Spanner\Query\Parameterizer as QueryParameterizer;
 use Colopl\Spanner\Query\Processor as QueryProcessor;
 use Colopl\Spanner\Schema\Builder as SchemaBuilder;
@@ -445,10 +446,14 @@ protected function prepareBinding(BaseQueryGrammar $grammar, mixed $value): mixe
 
     /**
      * @inheritDoc
-     * @param scalar|list<mixed>|null $value
+     * @param scalar|list<mixed>|Nested|null $value
      */
     public function escape($value, $binary = false)
     {
+        if ($value instanceof Nested) {
+            $value = $value->toArray();
+        }
+
         return is_array($value)
             ? $this->escapeArray($value, $binary)
             : parent::escape($value, $binary);

tests/ConnectionTest.php

@@ -19,6 +19,7 @@
 
 use Colopl\Spanner\Connection;
 use Colopl\Spanner\Events\MutatingData;
+use Colopl\Spanner\Query\Nested;
 use Colopl\Spanner\Session\SessionInfo;
 use Colopl\Spanner\TimestampBound\ExactStaleness;
 use Colopl\Spanner\TimestampBound\MaxStaleness;
@@ -600,6 +601,15 @@ public function test_escape_nested_array(): void
         $this->assertSame('[]', $conn->escape([[]]));
     }
 
+    public function test_escape_nested_object(): void
+    {
+        $conn = $this->getDefaultConnection();
+        $this->assertSame(
+            "[false, true, 0, 1, \"a\", 1.1]",
+            $conn->escape(new Nested([false, true, 0, 1, "a", 1.1]))
+        );
+    }
+
     public function test_getTablePrefix(): void
     {
         config()->set('database.connections.main.prefix', 'test_');

tests/Query/UnnestTest.php

@@ -21,6 +21,9 @@
 
 class UnnestTest extends TestCase
 {
+    /** @see https://cloud.google.com/spanner/quotas#query_limits */
+    public const SPANNER_PARAMETERS_LIMIT = 950;
+
     public function test_whereInUnnest(): void
     {
         $conn = $this->getDefaultConnection();
@@ -65,7 +68,7 @@ public function test_whereInUnnest__with_more_than_950_parameters(): void
         $qb = $conn->table($tableName);
         $id1 = $this->generateUuid();
         $id2 = $this->generateUuid();
-        $dummyIds = array_map($this->generateUuid(...), range(0, 950));
+        $dummyIds = array_map($this->generateUuid(...), range(0, self::SPANNER_PARAMETERS_LIMIT));
 
         $qb->insert([['userId' => $id1, 'name' => 't1'], ['userId' => $id2, 'name' => 't2']]);
         $given = $qb->whereInUnnest('userId', [$id1, $id2, ...$dummyIds])->pluck('userId')->sort()->values()->all();
@@ -97,5 +100,4 @@ public function test_whereNotInUnnest(): void
         $this->assertCount(2, $results);
         $this->assertSame($ids->skip(1)->values()->all(), $results->all());
     }
-
 }