-
Notifications
You must be signed in to change notification settings - Fork 86
Description
My initial approach was admittedly driven by eagerness to address the immediate issue, and I appreciate you taking the time to refine the implementation.
Regarding Windows Terminal detection, as you mentioned, we could always enable true color support on Windows.
About the set override functionality, I'm thinking whether we need to modify some function names in the existing ShouldColorize in control.rs and make some optimizations. I want to put the truecolor support set override into control.rs, but there are already functions named set_override and unset_override, which makes it difficult to distinguish between TrueColorSupport and ShouldColorize.
I also want to add that this isn't just a Windows-specific issue. On Linux, we might encounter similar situations where some terminals support ANSI 256 colors but don't explicitly indicate truecolor support. In such cases, it would be more appropriate to convert truecolor to ANSI 256 colors rather than falling back to 8 colors, as this would provide a better color representation.
It will take some time to perfect these changes and ensure everything works as expected. Thanks.
Originally posted by @cnlancehu in #194 (comment)