Skip to content

Commit 8fe817b

Browse files
committed
MapSchema: delete_by_index fix. closes #57
1 parent d10df2c commit 8fe817b

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

colyseus/serialization/schema/types/array_schema.lua

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function array_schema:delete_by_index(index)
8888

8989
self.items[dynamic_index] = nil
9090
end
91-
91+
9292
self.indexes[index] = nil
9393
end
9494

colyseus/serialization/schema/types/map_schema.lua

+9-6
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,18 @@ end
6565
function map_schema:delete_by_index(index)
6666
local dynamic_index = self.indexes[index]
6767

68-
-- delete key
69-
for i, k in pairs(self.dynamic_indexes) do
70-
if k == dynamic_index then
71-
table.remove(self.dynamic_indexes, i)
72-
break
68+
if dynamic_index ~= nil then
69+
-- delete key
70+
for i, k in pairs(self.dynamic_indexes) do
71+
if k == dynamic_index then
72+
table.remove(self.dynamic_indexes, i)
73+
break
74+
end
7375
end
76+
77+
self.items[dynamic_index] = nil
7478
end
7579

76-
self.items[dynamic_index] = nil
7780
self.indexes[index] = nil
7881
end
7982

0 commit comments

Comments
 (0)