Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding node from searchbar isn't a tracked change #3885

Closed
christian-byrne opened this issue Jun 27, 2024 · 0 comments · May be fixed by #3915
Closed

Adding node from searchbar isn't a tracked change #3885

christian-byrne opened this issue Jun 27, 2024 · 0 comments · May be fixed by #3915
Labels
Frontend Issue relates to the frontend UI (litegraph). Potential Bug User is reporting a bug. This should be tested.

Comments

@christian-byrne
Copy link

Expected Behavior

Adding nodes via dblclick>search should dispatch graphChanged event.

Actual Behavior

Adding a node from search bar isn't tracked by change tracker, graphChanged event isn't sent to listeners. New state isn't observed until a separate event triggers a new state check.

Steps to Reproduce

  1. Add console.log that prints on graphChanged events
  2. Double click graph -> Click to add node from search modal

Alternatively, add two nodes consecutively this way, without inputs in between, then try to use the undo hotkey.

Debug Logs

.

Other

No response

@christian-byrne christian-byrne added the Potential Bug User is reporting a bug. This should be tested. label Jun 27, 2024
@mcmonkey4eva mcmonkey4eva added the Frontend Issue relates to the frontend UI (litegraph). label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Issue relates to the frontend UI (litegraph). Potential Bug User is reporting a bug. This should be tested.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants