-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components/modal-pages): allow use of iconLeft on secondaryButton #1812
feat(components/modal-pages): allow use of iconLeft on secondaryButton #1812
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/e6on0vvu0 |
🦋 Changeset detectedLatest commit: 89ae2b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
First of all, it seems to me that this change is not complete. How do you want to expose this prop to the main components? You just added the prop to an internal component, so I'm a bit confused how this should be used.
Also, I would suggest to at least open an issue first, describing what feature/changes you would like to implement, as we need to make a decision first how to proceed.
For instance, the requirements here are not so clear, meaning for example if this is the only use case, how much we want to build as defaults into the components (also from a UX perspective), etc.
Hmm, i was working with
I opened an issue as you suggested, added the details from the ui-team's findings and the dependent issue. |
Summary
In discount application's rule builder quick selection context we use the secondary button of modal pages to trigger 'revert changes'. Based on the decision by the ui-team, revert changes button should have the corresponding revert icon. These changes allow the use of an icon with the secondary button of the modal pages.