chore: replace rcfile with Prettier API for reading Prettier config
#2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 04a60aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 04a60aa. |
kark
force-pushed
the
kk-remove-rcfile
branch
from
d372067 to
04a60aa
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partway towards resolving #2953.
We use
[email protected]increate-mc-app,mc-scriptsandl10npackages for reading Prettier config. The package is used in the most recent version but it hasn't been updated by the library authors for years. The package uses[email protected]under the hood and there is a reported issue with the json5 that causes the Dependabot alert.We can use the native Prettier API for reading Prettier config.