-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] FEC-156: migration to React 19 #3687
Draft
kark
wants to merge
49
commits into
main
Choose a base branch
from
preview/fec-156-react19
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 39 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
182b908
chore: ground work
kark cabd394
chore: uikit packages
kark 178d507
refactor: updates resulting from uikit changes
kark 30e2253
chore: initial changeset
kark 01a8dc8
chore: react hooks
kark bf343b7
fix: further default props occurrences
kark f3eaaa0
fix: type errors
kark 0626b3d
fix: improve types
kark a1acdb9
fix: icon type
kark fbd4b78
chore: use new uikit rc
kark 4095d04
chore: cleanup
kark d191409
fix: custom view loading
kark 314fd03
fix: types in starter templates
kark bbd51b9
fix: tests
kark a01a982
chore: use strict mode in playground
kark 26c9817
chore: use tag for uikit packages
kark 8a4addd
fix: failing credentials storage tests
kark f283092
fix: use skiplibcheck temporarily
kark 43b7296
fix: try react-modal patch
kark 41401a9
fix: channel details tests
kark 6dc0289
fix: pagination
kark fa6cfdb
chore: test utils
kark 852195f
chore: use new tag
kark 5f4c60f
chore: cleanup resolutions
kark 711c5b3
chore: 0.0.0-fec-155-react-19-20250122162343
kark b901953
chore: react-intl 7.x
kark 50aa17b
chore: skiplibcheck
kark 7d052d6
fix: missing key prop
kark 08b5c1f
fix: act warnings
kark bfe7ef6
Merge branch 'main' into preview/fec-156-react19
CarlosCortizasCT 9f2fe3c
Merge branch 'main' into preview/fec-156-react19
CarlosCortizasCT 7ca60f6
Merge branch 'main' into preview/fec-156-react19
CarlosCortizasCT 142982e
refactor: change uikit dependencies to use the dist tag instead of a …
CarlosCortizasCT 08dcab9
Merge branch 'main' into preview/fec-156-react19
ragafus 3df5c48
fix: wrong @commercetools-frontend/application-components peerDepende…
ragafus 87405b1
fix: wrong pnpm version
ragafus 48cceca
fix: typecheck errors
ragafus 9112ead
Merge branch 'main' into preview/fec-156-react19
ragafus 0e96026
fix: typecheck errors due to @emotion/react version
ragafus 23e0763
refactor: remove react-modal patch
ragafus b7e848c
refactor: downgrade @emotion/react to 11.13.5
ragafus 45df190
Merge branch 'main' into preview/fec-156-react19
ragafus 87a1843
refactor: import the JSX namespace
ragafus c9e8f4b
refactor: remove unnecessary castings
ragafus d4d04d8
fix: match emotion related comments with the ones existing in main
ragafus ac7e93f
fix: application-components and application-shell to use app-kit 22.42.0
ragafus fb36583
Merge branch 'main' into preview/fec-156-react19
ragafus 26ef3eb
fix: missing @commercetools-local/visual-testing-app dependencies
ragafus 6e45666
Merge branch 'main' into preview/fec-156-react19
ragafus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| '@commercetools-applications/merchant-center-custom-view-template-starter-typescript': major | ||
| '@commercetools-applications/merchant-center-template-starter-typescript': major | ||
| '@commercetools-frontend/application-shell-connectors': major | ||
| '@commercetools-frontend/application-components': major | ||
| '@commercetools-applications/merchant-center-custom-view-template-starter': major | ||
| '@commercetools-applications/merchant-center-template-starter': major | ||
| '@commercetools-website/components-playground': major | ||
| '@commercetools-frontend/react-notifications': major | ||
| '@commercetools-frontend/application-config': major | ||
| '@commercetools-frontend/jest-preset-mc-app': major | ||
| '@commercetools-frontend/application-shell': major | ||
| '@commercetools-frontend/actions-global': major | ||
| '@commercetools-frontend/permissions': major | ||
| '@commercetools-local/visual-testing-app': major | ||
| '@commercetools-frontend/sentry': major | ||
| '@commercetools-frontend/i18n': major | ||
| '@commercetools-frontend/l10n': major | ||
| '@commercetools-frontend/sdk': major | ||
| '@commercetools-local/playground': major | ||
| '@commercetools-backend/eslint-config-node': major | ||
| '@commercetools-backend/express': major | ||
| '@commercetools-backend/loggers': major | ||
| '@commercetools-frontend/assets': major | ||
| '@commercetools-frontend/babel-preset-mc-app': major | ||
| '@commercetools-frontend/browser-history': major | ||
| '@commercetools-frontend/codemod': major | ||
| '@commercetools-frontend/constants': major | ||
| '@commercetools-frontend/create-mc-app': major | ||
| '@commercetools-frontend/cypress': major | ||
| '@commercetools-frontend/eslint-config-mc-app': major | ||
| '@commercetools-frontend/jest-stylelint-runner': major | ||
| '@commercetools-frontend/mc-dev-authentication': major | ||
| '@commercetools-frontend/mc-html-template': major | ||
| '@commercetools-frontend/mc-scripts': major | ||
| '@commercetools-frontend/notifications': major | ||
| '@commercetools-frontend/url-utils': major | ||
| --- | ||
|
|
||
| Upgrade to React 19 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| /// <reference types="@commercetools-frontend/application-config/client" /> | ||
|
|
||
| import ReactDOM from 'react-dom'; | ||
| import { createRoot } from 'react-dom/client'; | ||
| import EntryPoint from './components/entry-point'; | ||
|
|
||
| ReactDOM.render(<EntryPoint />, document.getElementById('app')); | ||
| const container = document.getElementById('app'); | ||
| const root = createRoot(container as Element); | ||
| root.render(<EntryPoint />); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| import ReactDOM from 'react-dom'; | ||
| import { createRoot } from 'react-dom/client'; | ||
| import EntryPoint from './components/entry-point'; | ||
|
|
||
| ReactDOM.render(<EntryPoint />, document.getElementById('app')); | ||
| const container = document.getElementById('app'); | ||
| const root = createRoot(container); | ||
| root.render(<EntryPoint />); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| /// <reference types="@commercetools-frontend/application-config/client" /> | ||
|
|
||
| import ReactDOM from 'react-dom'; | ||
| import { createRoot } from 'react-dom/client'; | ||
| import EntryPoint from './components/entry-point'; | ||
|
|
||
| ReactDOM.render(<EntryPoint />, document.getElementById('app')); | ||
| const container = document.getElementById('app'); | ||
| const root = createRoot(container as Element); | ||
| root.render(<EntryPoint />); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ragafus I suggest to downgrade to
11.13.5as there are some TS errors in11.14.0.We are working on a fix: #3722
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this comment is not longer needed as the fix was already released and this branch refreshed with the corresponding version.
@emmenko can we close this comment?