You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a similar issue, but mine got automatically rotated after the edit window (auto rotate when edit image without any further rotation), I think this is rooted from this piece of code in EditActivity.kt
var imageRotation = 0
val rotation = imageRotation % 360
val newRotation = rotation + 90
then imageRotation will be changed based on newRotation
Even though I cannot reproduce the exact problem (rotated immediately after the Edit Image click), the error on my testing machine is that after clicking "Edit Image" then perform no rotation (click "Save" or "Rotate" 4 times so that the picture gets back to the original position then click "Save"), the image will be rotated 90 degree.
Originally, I thought the problem was the logic in EditActivity.kt that somehow triggers rotation without clicking "Rotate". However, the problem is in the implementation of rotateImage() function in TransformImageImpl". The rotateImage()` function expects 90, 180, 270 for rotation, however, when the given rotating degree = 0 (user perform no rotation), the implementation assume it should be rotated 90 degree.
Summary
After clicking "Edit Image", picture (always?) seems to be in incorrect orientation (rotated 90 degrees counter-clockwise).
There is related issue #5502, but I'm not sure if that applies?
Steps to reproduce
Step 1 of 4: Media Details
page)Edit Image
Expected behaviour
expect that after clicking
Edit Image
, image will be shown in the same (correct) orientation that is was shown in step2.
aboveActual behaviour
image is shown rotated 90 degrees CCW.
Device name
Samsung Galaxy S23+
Android version
Android 14 (OneUI 6.1)
Commons app version
5.0.1~af028cbdd (latest F-droid)
Device logs
Screen-shots
small_Screen_Recording_20240504_213904_Commons.mp4
Would you like to work on the issue?
None
The text was updated successfully, but these errors were encountered: