Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested fixes for "showcase view whole nearby activity" #2872

Open
amire80 opened this issue Apr 10, 2019 · 16 comments · May be fixed by #5870
Open

Suggested fixes for "showcase view whole nearby activity" #2872

amire80 opened this issue Apr 10, 2019 · 16 comments · May be fixed by #5870
Assignees
@devbytespark
Labels
good first issue user experience

Comments

@amire80
Copy link
Contributor

amire80 commented Apr 10, 2019

Summary:

A couple of things should be fixed for the benefit of the users and the translators.

Steps to reproduce:

Check the messages "showcase view whole nearby activity" and "search this area".

The message "showcase view whole nearby activity" currently says: "Clicking on 'SEARCH THIS AREA' locks the map and launches a nearby search around that location."

The words "SEARCH THIS AREA" in the message above probably refer to the message with the key "search this area", the text of which is "Search this area" - not in all-caps. Several things to fix in the messages' text:

  • The capitalization must be consistent.
  • Don't use all-caps for any kind of emphasis or design that must be translatable because most alphabets don't have lowercase and uppercase distinction.

Furthermore, perhaps the message "showcase view whole nearby activity" can automatically include the text of the other message, so that the consistency would be enforced and translators wouldn't have to copy things.
@fredrikjonasson
Copy link

I would like to start my contribution with this one.

@fredrikjonasson
Copy link

Screenshot_1555621111
Screenshot_1555621192

I took a quick look and it seems to be consistent capitalization towards the user. The key "Search this area" indeed seems to refer to the text as you describe. Should it be changed anyway to be consistent towards the developer?

@HarunJr
Copy link

HarunJr commented Sep 12, 2019

Hello @amire80, I'd like to contribute to this issue.

@amire80
Copy link
Contributor Author

amire80 commented Sep 12, 2019

Go for it. I just reported the bug, I'm usually not a developer on this project. It's probably not very difficult. Thank you!

@HarunJr
Copy link

HarunJr commented Sep 12, 2019 •
edited
Loading

Let me get it right @amire80,
First, remove capitalisation in strings.xml where it's written Clicking on 'SEARCH THIS AREA'
Then automatically reference the value 'Search this area' from both the key showcase_view_whole_nearby_activity and search_this_area.
is that correct?

HarunJr added a commit to HarunJr/apps-android-commons that referenced this issue Sep 12, 2019
@HarunJr
Change capitalisation consistency
301ab88 
changed line 135 where capitalised as 'SEARCH THIS AREA' to a global
'&searcharea' making it normalcase and also referenced also from line 457

Closes commons-app#2872
@HarunJr HarunJr mentioned this issue Sep 12, 2019
Closed
@amire80
Copy link
Contributor Author

amire80 commented Sep 13, 2019

Yes. The capitalization should be consistent. My suggestion is not to use ALL CAPS, but to write "Search this area", because there are many languages in which ALL CAPS are irrelevant, such as Chinese, Hindi, and Arabic. However, maybe the designer of the app has a different opinion about this. The important thing is that it will be consistent.

And if you can automatically insert "Search this area" into "Clicking on 'SEARCH THIS AREA'" as a parameter, then the capitalization will become consistent automatically. (By "parameter" I mean something like %1$s.)

@neslihanturan
Copy link
Collaborator

Hi @HarunJr , thanks for your interest but currently related classes are being edited. So what about waiting until #2969 is merged and after that if the issue still persist you can solve.

@HarunJr
Copy link

HarunJr commented Sep 14, 2019

No problem @neslihanturan. I shall wait.

@FawziyahAlebiosu
Copy link
Contributor

Looks to me like inside of the strings.xml file, search this area has been removed and is no longer capitalized. See here:

apps-android-commons/app/src/main/res/values/strings.xml

Line 452 in 0ad269d

<string name="search_this_area">Search this area</string>

Can this issue be closed now?

@FawziyahAlebiosu
Copy link
Contributor

I spoke too soon!
@HarunJr looks like all that is left is for this line to be made to lowercase and then both strings will be consistent:

apps-android-commons/app/src/main/res/values/strings.xml

Line 310 in 0ad269d

<string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles.\n\nClicking on \'SEARCH THIS AREA\' locks the map and launches a nearby search around that location.</string>

@macgills
Copy link
Collaborator

Buttons in android by default capitalise all the text that you set to them so I doubt SEARCH THIS AREA was ever in the codebase as all caps. I am not 100% on what to do here because referencing our button SEARCH THIS AREA with the non capitalised text Search this Area weakens their connection in English.

I'd say the best way it to probably paramterise showcase_view_whole_nearby_activity and Uppercase search_this_area as works by locale.

@neslihanturan any opinions on how this should look?

@Henry4669
Copy link

Hi, is this issue resolved? If not, then can I contribute to this issue?

@Henry4669
Copy link

@neslihanturan Hi, sorry I forgot to ping one of the contributors.
If I can contribute to this issue, may I ask which activities the strings are used in?

@Henry4669
Copy link

Hi @nicolas-raoul, sorry for bothering you. @neslihanturan doesn't seem to be active but I have done exactly as @amire80 had asked, which involved, for example, changing the capitalisation properties of a button in the map activity.
image
I would like your opinion on how the button should look. Do you think it should be changed?
Also, please assign me if you think it needs to be changed.

@Henry4669 Henry4669 mentioned this issue Oct 29, 2022
Closed
@devbytespark
Copy link

devbytespark commented Oct 19, 2024 •
edited
Loading

Hey @nicolas-raoul could I work on this? The affected classes from issue #2969 have been refactored now, seems like a simple fix.

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Oct 19, 2024 •
edited
Loading

Indeed, the button has been removed recently I believe.

EDIT: Actually the button has been removed from Nearby, but still exists in Explore>Map.

@devbytespark devbytespark linked a pull request Oct 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devbytespark devbytespark

Labels
good first issue user experience
Projects
None yet
Milestone
No milestone
9 participants
@nicolas-raoul @amire80 @neslihanturan @macgills @HarunJr @fredrikjonasson @FawziyahAlebiosu @Henry4669 @devbytespark