Skip to content

Commit ef1d9c1

Browse files
authored
Merge pull request #87 from community-of-python/refactor-otel-structlog
Refactor enriching log with trace and span ids
2 parents 4c0ebf1 + 9875401 commit ef1d9c1

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

microbootstrap/instruments/logging_instrument.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,16 @@ def fill_log_message(
5757

5858

5959
def tracer_injection(_: WrappedLogger, __: str, event_dict: EventDict) -> EventDict:
60-
event_dict["tracing"] = {}
61-
current_span: typing.Final[trace.Span] = trace.get_current_span()
62-
if current_span == trace.INVALID_SPAN:
60+
current_span = trace.get_current_span()
61+
if not current_span.is_recording():
62+
event_dict["tracing"] = {}
6363
return event_dict
6464

65-
span_context: typing.Final[trace.SpanContext] = current_span.get_span_context()
66-
if span_context == trace.INVALID_SPAN_CONTEXT:
67-
return event_dict
68-
69-
event_dict["tracing"]["trace_id"] = format(span_context.span_id, "016x")
70-
event_dict["tracing"]["span_id"] = format(span_context.trace_id, "032x")
71-
65+
current_span_context = current_span.get_span_context()
66+
event_dict["tracing"] = {
67+
"span_id": trace.format_span_id(current_span_context.span_id),
68+
"trace_id": trace.format_trace_id(current_span_context.trace_id),
69+
}
7270
return event_dict
7371

7472

0 commit comments

Comments
 (0)