Skip to content

Commit 15e0fb4

Browse files
committed
Refine ProGuard protection rules
1 parent 9c847bc commit 15e0fb4

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

.idea/modules.xml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

MediaPhone/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232

3333
release {
3434
minifyEnabled true
35-
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-mediaphone.txt'
35+
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-mediaphone.txt'
3636

3737
shrinkResources true
3838
}

MediaPhone/src/main/java/ac/robinson/mediaphone/MediaPhoneActivity.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1858,7 +1858,7 @@ protected void exportContent(final String narrativeId, final boolean isTemplate)
18581858
res.getInteger(R.integer.export_maximum_text_percentage_height_with_image));
18591859
settings.put(MediaUtilities.KEY_TEXT_SPACING, res.getDimensionPixelSize(R.dimen.export_icon_text_padding));
18601860
settings.put(MediaUtilities.KEY_TEXT_CORNER_RADIUS,
1861-
res.getDimensionPixelSize(R.dimen.export_icon_text_corner_radius));
1861+
res.getDimensionPixelSize(R.dimen.export_icon_text_corner_radius));
18621862

18631863
SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(MediaPhoneActivity.this);
18641864

@@ -1874,10 +1874,12 @@ protected void exportContent(final String narrativeId, final boolean isTemplate)
18741874
switch (item) {
18751875
case 0: // MOV/MP4
18761876
// set exported video size
1877-
int outputSize;
1877+
int outputSize = res.getInteger(R.integer.default_video_quality);
18781878
try {
18791879
String requestedExportSize = preferences.getString(getString(R.string.key_video_quality), null);
1880-
outputSize = Integer.parseInt(requestedExportSize);
1880+
if (requestedExportSize != null) {
1881+
outputSize = Integer.parseInt(requestedExportSize);
1882+
}
18811883
} catch (Exception e) {
18821884
outputSize = res.getInteger(R.integer.default_video_quality);
18831885
}
@@ -1896,12 +1898,14 @@ protected void exportContent(final String narrativeId, final boolean isTemplate)
18961898
settings.put(MediaUtilities.KEY_IMAGE_QUALITY, res.getInteger(R.integer.camera_jpeg_save_quality));
18971899

18981900
// set audio resampling rate: -1 = automatically selected (default); 0 = none
1899-
int newBitrate;
1901+
int newBitrate = res.getInteger(R.integer.default_resampling_bitrate);
19001902
try {
19011903
String requestedBitrateString =
19021904
preferences.getString(getString(R.string.key_audio_resampling_bitrate),
19031905
null);
1904-
newBitrate = Integer.parseInt(requestedBitrateString);
1906+
if (requestedBitrateString != null) {
1907+
newBitrate = Integer.parseInt(requestedBitrateString);
1908+
}
19051909
} catch (Exception e) {
19061910
newBitrate = res.getInteger(R.integer.default_resampling_bitrate);
19071911
}

MediaUtilities

0 commit comments

Comments
 (0)