Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove elevation >= 0 filter from observations api #21

Open
emiliom opened this issue Dec 24, 2020 · 2 comments
Open

Remove elevation >= 0 filter from observations api #21

emiliom opened this issue Dec 24, 2020 · 2 comments

Comments

@emiliom
Copy link
Member

emiliom commented Dec 24, 2020

See SQL WHERE condition at https://github.com/communitysnowobs/cso-api/blob/master/src/observations/query.js#L17

Having that filter makes it impossible to obtain some of the data in the CSO database and therefore reduces the value of the CSO observations API for QA/QC'ing the CSO database. Also, it assumes the elevation data are perfect, and that no valid data could be associated with negative elevation values generated by the Google Elevation API.

@dfosterhill
Copy link

dfosterhill commented Dec 25, 2020 via email

@emiliom
Copy link
Member Author

emiliom commented Dec 30, 2020

Right. I'm going to start compiling the discussions we've had recently about the API's, the CSO database, and so on, to facilitate our discussions on a future call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants