Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package LDpred2 scripts #218

Open
deepchocolate opened this issue Jan 16, 2024 · 3 comments
Open

Package LDpred2 scripts #218

deepchocolate opened this issue Jan 16, 2024 · 3 comments

Comments

@deepchocolate
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The ldpred2 scripts works as is, but it's not optimal in terms of distribution and development.

Describe the solution you'd like
More code can be moved into usecases/LDpred2/fun.R and create an R-package based on this. The R scripts in usecases/LDpred2/ would then be interfaces to this R-package.

  • Easier development as there is a good library for package development in R (devtools).
  • This would simplify use of these scripts independently of the containers.
  • Dependencies can be loaded through the R-package, rather than this obscure workaround to resolve script paths:
    coms <- commandArgs()
    coms <- coms[substr(coms, 1, 7) == '--file=']
    dirScript <- dirname(substr(coms, 8, nchar(coms)))
    source(paste0(dirScript, '/fun.R'))
@deepchocolate
Copy link
Contributor Author

deepchocolate commented Jan 17, 2024

The most important thing: Any package name suggestion? Maybe something like "ldpred2Commander" (in reference to being a command-line interface to ldpred2)... @espenhgn

@espenhgn
Copy link
Contributor

Hi @deepchocolate - I have no strong opinion on naming this package!

Copy link

This issue appears to be stale due to non-activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants