Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Revision timestamps in lockfiles change depending on different settings #16523

Open
1 task done
fschoenm opened this issue Jun 21, 2024 · 0 comments
Open
1 task done

Comments

@fschoenm
Copy link

What is your question?

When we introduced lockfiles, I noticed that e.g. when creating/updating the lockfile for different OS or different build types, it sometimes (?) updates the timestamps of the revisions. For example, I created a lockfile on Windows first and had this in my lockfile:

"double-conversion/3.3.0#33321c201741cc32b51169c6d2d05e60%1684478632.238",

After updating the lockfile to also support Linux builds, it changed to

"double-conversion/3.3.0#33321c201741cc32b51169c6d2d05e60%1710153244.734",

which has the same revision but a different timestamp.

I found in the design document, that adding timestamps was necessary to "have ordered lists of versions and revisions" but I'm not really sure what that means.

Now my question is just to clarify, if this can lead to any problems or has any side effect we should be aware of? Our CI builds work on Windows and Linux with the timestamp changes in the lockfile, so it doesn't seem to have an apparent effect. Would everything run as expected, no matter which of the two timestamps above we'd have in the lockfile or is there a situation in which it'd accidentally break?

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant