Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] conan list filtering option asks users to use scope patterns when those don't work in that context #16545

Closed
RubenRBS opened this issue Jun 25, 2024 · 2 comments · Fixed by #16559
Closed

[bug] conan list filtering option asks users to use scope patterns when those don't work in that context #16545

RubenRBS opened this issue Jun 25, 2024 · 2 comments · Fixed by #16559
Assignees
@memsharded
Labels
stage: triaging

Comments

@RubenRBS
Copy link
Member

RubenRBS commented Jun 25, 2024 •
edited
Loading

Describe the bug

When running conan install with the --filter-options argument, you're supposed not to scope the option. But if you do so, you get a warning like

WARN: legacy: Unscoped option definition is ambiguous.
Use '&:shared=True' to refer to the current package.
Use '*:shared=True' or other pattern if the intent was to apply to dependencies

which disappears if you use a scope, but then the filter does not work properly

How to reproduce it

No response
@RubenRBS RubenRBS mentioned this issue Jun 25, 2024
Closed
1 task
@RubenRBS
Copy link
Member Author

I might have missremembered and you're actually supposed to scope it with *:. Still, the point stands than then it's not intuitive and we should check if we can do something about it

@memsharded memsharded self-assigned this Jun 27, 2024
@memsharded
Copy link
Member

The only test that applies is c.run(f"list *:* -fs os=Windows -fo *:shared=False --format=json {r}"), so I am not sure if the intent is not to scope options. Actually, the warnings were added with the intention to always scope options everywhere, including profiles, and also in the --filter-options. The idea is that the filter will be what you would put in a profile, and get the same warning as if you use it in a profile.

The test doing it seems to work:

conan/test/integration/command_v2/list_test.py

Line 891 in 88d0358

c.run(f"list *:* -fs os=Windows -fo *:shared=False --format=json {r}")
, with the scope.

@RubenRBS RubenRBS mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memsharded memsharded

Labels
stage: triaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow -fo in conan list to use &: scope to refer to all packages being listed RubenRBS/conan
2 participants
@RubenRBS @memsharded