[fix] PackagesList.only_recipes does not return anything #18834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
memsharded
reviewed
Aug 27, 2025
conan/api/model/list.py
Outdated
| for rrev_dict in ref_dict.get("revisions", {}).values(): | ||
| rrev_dict.pop("packages", None) | ||
| return result | ||
| return self.recipes.copy() |
There was a problem hiding this comment.
This is redundant. The current usages of only_recipes in Conan do not use the return value, better to just drop it
There was a problem hiding this comment.
Dropped in the commit 7b0f9e3
Signed-off-by: Uilian Ries <[email protected]>
memsharded
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exploring conan-io/examples2#193, the PackagesList.only_recipes method has an empty dict as a result, and it's not filled.
This PR adds value to be returned when using it.
Still, I'm not sure if it's worth keeping that result returned, because the method changes its own
self.recipes. Another option would be removing theresultonly.Changelog: Omit
Docs: Omit
developbranch, documenting this one.