-
Notifications
You must be signed in to change notification settings - Fork 378
adding conan build in the tutorial #4152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
czoido
merged 2 commits into
conan-io:develop2
from
memsharded:feature/conan_build_tutorial
Jul 4, 2025
Merged
adding conan build in the tutorial #4152
czoido
merged 2 commits into
conan-io:develop2
from
memsharded:feature/conan_build_tutorial
Jul 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
reviewed
Jul 1, 2025
| If you inspect the ``conanfile.py``, you can see it contains a ``build()`` method, with the instructions how to | ||
| configure and build this project, using some Conan helpers such as ``cmake.configure()`` and ``cmake.build()``. | ||
|
|
||
| It is not important to fully understand the ``build()`` method now, it will explained later in the tutorial. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| It is not important to fully understand the ``build()`` method now, it will explained later in the tutorial. | |
| It is not important to fully understand the ``build()`` method now, it will be explained later in the tutorial. |
| The ``conan new`` command creates a simple project containing a ``conanfile.py``, a ``CMakeLists.txt`` and some C++ code. | ||
| If you inspect the ``conanfile.py``, you can see it contains a ``build()`` method, with the instructions how to |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| If you inspect the ``conanfile.py``, you can see it contains a ``build()`` method, with the instructions how to | |
| If you inspect the ``conanfile.py``, you can see that it contains a ``build()`` method, with the instructions on how to |
czoido
reviewed
Jul 2, 2025
Contributor
|
Pending to update examples2, I created an issue there so we don't forget conan-io/examples2#189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4151
Opening it for team feedback, maybe this is not the best location or approach.