feat: add checksum_algorithm configuration option #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for configuring the checksum algorithm used when uploading objects to S3. Users can now specify CRC32, CRC32C, SHA1, SHA256, or CRC64NVME algorithms via the checksum_algorithm source configuration. Signed-off-by: Mathias Bogaert <[email protected]>
taylorsilva
requested changes
Nov 9, 2025
Comment on lines
+61
to
+71
| if source.ChecksumAlgorithm != "" { | ||
| validAlgorithms := map[string]bool{ | ||
| "CRC32": true, | ||
| "CRC32C": true, | ||
| "SHA1": true, | ||
| "SHA256": true, | ||
| "CRC64NVME": true, | ||
| } | ||
| if !validAlgorithms[source.ChecksumAlgorithm] { | ||
| return false, "checksum_algorithm must be one of: CRC32, CRC32C, SHA1, SHA256, CRC64NVME" | ||
| } |
Member
There was a problem hiding this comment.
Hard-coded lists are always suspect because they become things we need to stay on top of and update (adding and removing items from the list). To reduce maintenance burden, can we leverage something in the AWS SDK?
Digging into the types.ChecksumAlgorithm: https://github.com/aws/aws-sdk-go-v2/blob/a432037f9e94425a2482aa0511f34bc90957462d/service/s3/types/enums.go#L221
There's a handy .Values() function that returns a list of valid values: https://github.com/aws/aws-sdk-go-v2/blob/a432037f9e94425a2482aa0511f34bc90957462d/service/s3/types/enums.go#L236-L244
Can we use that as the source of truth instead of hard-coding the list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configuring the checksum algorithm used when uploading objects to S3. Users can now specify CRC32, CRC32C, SHA1, SHA256, or CRC64NVME algorithms via the checksum_algorithm source configuration.
Closes #161